larryzhu2018 commented on a change in pull request #7141: [AIRFLOW-6544] add log_id to end-of-file mark and also add an index config for logs URL: https://github.com/apache/airflow/pull/7141#discussion_r368107397
########## File path: airflow/utils/log/es_task_handler.py ########## @@ -53,9 +53,11 @@ class ElasticsearchTaskHandler(FileTaskHandler, LoggingMixin): PAGE = 0 MAX_LINE_PER_PAGE = 1000 + # 16 is reasonable in this case + # pylint: disable-msg=too-many-arguments def __init__(self, base_log_folder, filename_template, log_id_template, end_of_log_mark, - write_stdout, json_format, json_fields, Review comment: the default right now is "*" which has the same semantic as before and it is backward compatible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services