aoelvp94 commented on PR #73015: URL: https://github.com/apache/airflow/pull/73015#issuecomment-6386611579
> Thanks for reworking this. > > One small thing: `view_url_template()` still builds the URL from `prefix`, so with `archive_key` set the link points at the bucket root. Could it point at the archive object instead? > > Also the docs call the swap atomic, but it's two renames with a short gap where the bundle dir doesn't exist. Maybe just "a swap into place". Done! thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
