anisayakmitra-in opened a new pull request, #75583:
URL: https://github.com/apache/airflow/pull/75583
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
### Description
Part of meta issue #35442 / systematic overlooked test resolution (#72265).
Adds dedicated unit tests for:
1.
`providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor_config.py`
- Covers `_fetch_templated_kwargs` (valid JSON vs default fallback).
- Covers `_fetch_config_values` (pruning None values).
- Covers `build_submit_kwargs` (default container overrides, merging
templated kwargs, rejecting unsupported nodeOverrides and
eksPropertiesOverride, and JSON serialization validation).
2.
`providers/amazon/src/airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py`
- Covers `_fetch_templated_kwargs` and `_fetch_config_values` with
fallback defaults.
- Covers `build_task_kwargs`:
- Mutual exclusivity check between `capacity_provider_strategy` and
`launch_type`.
- Cluster lookup fallback to Fargate when no default capacity provider
strategy is configured.
- EC2 launch type dropping `platform_version`.
- Container overrides configuration and command initialization.
- Networking configuration parsing (subnets, security groups, assign
public IP) and validation error when subnets are missing.
- JSON serialization error handling.
Retires both entries from `OVERLOOKED_TESTS` in
`airflow-core/tests/unit/always/test_project_structure.py`.
### Tests
-
`providers/amazon/tests/unit/amazon/aws/executors/batch/test_batch_executor_config.py`
-
`providers/amazon/tests/unit/amazon/aws/executors/ecs/test_ecs_executor_config.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
