ShivamSharma43 opened a new pull request, #75667:
URL: https://github.com/apache/airflow/pull/75667
`JenkinsBuildSensor` documents that it passes once the watched build has
finished, regardless of the outcome, but with the default `target_states` it
raises as soon as a build fails.
Jenkins reports a failed build with the result `FAILURE` (the possible
results are `SUCCESS`, `UNSTABLE`, `FAILURE`, `NOT_BUILT` and `ABORTED`). The
default `target_states` was `["SUCCESS", "FAILED"]`, and `FAILED` is never
returned by Jenkins, so a failed build fell through to the `AirflowException`
"Build N finished with a result FAILURE, which does not meet the target state
['SUCCESS', 'FAILED']".
This changes the default to `["SUCCESS", "FAILURE"]` and documents the
`target_states` parameter, which was missing from the docstring. Users who pass
`target_states` explicitly are not affected.
Testing:
- Added `test_poke_failed_build_passes_with_default_target_states`, which
fails on `main` with the exception above and passes with this change.
- `pytest providers/jenkins/tests` passes (28 tests), run in a Linux
(python:3.11) container.
- `prek run --from-ref main` for the `pre-commit` and `manual` stages
passes, run with `SKIP_BREEZE_PREK_HOOKS=1` because breeze is not available in
my environment. Because of that, I ran mypy (2.4.0, repository config) directly
on the changed files: no errors in them.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below): Claude Code
Generated-by: Claude Code following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
