ieCecchetti commented on code in PR #75684:
URL: https://github.com/apache/airflow/pull/75684#discussion_r4383715845
##########
airflow-core/src/airflow/ui/src/hooks/useShortcut.ts:
##########
@@ -51,7 +57,15 @@ export const useShortcut = ({
const { t: translate } = useTranslation();
const { register, unregister } = useShortcutRegistry();
- const ref = useHotkeys(keys, callback, options, dependencies);
+ const ref = useHotkeys(
+ keys,
+ callback,
+ {
+ ...options,
+ ignoreEventWhen: (event) => isFromMonacoEditor(event) ||
(options?.ignoreEventWhen?.(event) ?? false),
Review Comment:
I think that this one used like this ignores every key inside a Monaco
editor, not just the printable keys the issue was about.
Can you check? Maybe i havent get well the aim of the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
