arnavsingh0418 opened a new pull request, #75684: URL: https://github.com/apache/airflow/pull/75684
closes: #75661 Typing "g" in the Trigger Dag dialog's Configuration JSON field toggled the grid/graph view instead of entering the letter. The same happened for any other single-key shortcut typed into a Monaco editor. **Cause:** `react-hotkeys-hook` skips keys typed into form fields (`input`, `textarea`, `select`). Monaco 0.57 turns on its `editContext` option by default where the browser supports the EditContext API (Chrome, Edge). The element that takes input is then a plain `div.native-edit-context` instead of a hidden `<textarea>`, so the hotkey library no longer sees a form field. The grid/graph shortcut fires and its `preventDefault` swallows the key. **Fix:** `useShortcut`, the wrapper every UI shortcut goes through, now passes an `ignoreEventWhen` that skips key events coming from inside a `.monaco-editor`. That restores the behavior from before EditContext, when Monaco's hidden `<textarea>` made the library skip these events. A caller's own `ignoreEventWhen` is still applied. The library keeps `ignoreEventWhen` in a ref and leaves it out of its options comparison, so the listener is not re-bound on every render. **Tests:** two cases in `useShortcut.test.tsx`: - A key pressed inside a `.monaco-editor` does not fire the shortcut, and the same key pressed elsewhere does. This test fails without the fix. - A caller's `ignoreEventWhen` is still honored. Run in `airflow-core/src/airflow/ui`: - `vitest run src/hooks/useShortcut.test.tsx`: 6 passed. - The test files of every component that uses `useShortcut` (`SearchBar`, `PanelButtons`, `Code`, `CallbackLogs`, `LogSearchInput`, `Logs`) plus `useShortcut`: 7 files, 46 tests passed. - `eslint` and `prettier --check` on the changed files pass, and `tsc --p tsconfig.app.json` passes. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
