vincbeck commented on PR #75913: URL: https://github.com/apache/airflow/pull/75913#issuecomment-6523077406
> Hello @vincbeck, thanks for your review. I tried to fix as much as I can. > > I still have 3 things that came up : > > * My refactor made all grants use `preferred_username` / `clientId` / `"service-account"`. Before, the password grant required `preferred_username`. So a real user could now show up as `service-account` if the claim is missing. I'd keep the fallback only for client credentials and JWT-bearer. OK? Ok > * Any Airflow API token can be refreshed at `/auth/token/cli`, not only CLI tokens. The expiry is kept, so a session is never extended. > * `revoke_token` only exists since Airflow 3.2.0, so refresh fails with a 500 on 3.0 and 3.1. Can I bump the provider to `apache-airflow>=3.2.0`? Can you handle both branches? Or that creates a lot of complexity? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
