aaron-y-chen commented on code in PR #74674:
URL: https://github.com/apache/airflow/pull/74674#discussion_r4436713639


##########
go-sdk/sdk/context.go:
##########
@@ -85,13 +87,22 @@ type TaskInstance struct {
 }
 
 // DagRun identifies the Dag run the current task instance belongs to and
-// carries its scheduling timestamps. The *time.Time fields are nil when the
-// supervisor did not provide a value (for example, a manually triggered run
-// without a logical date).
+// carries its scheduling timestamps, how it was created, and its conf. The
+// *time.Time fields are nil when the supervisor did not provide a value (for
+// example, a manually triggered run without a logical date).
 type DagRun struct {
        DagID             string
        RunID             string
        LogicalDate       *time.Time
        DataIntervalStart *time.Time
        DataIntervalEnd   *time.Time
+       RunAfter          time.Time
+       // RunType says how the run was created, such as
+       // [github.com/apache/airflow/go-sdk/airflow.DagRunTypeManual].
+       RunType genmodels.DagRunType

Review Comment:
    Added `sdk.DagRunType` for the `RunType` field, with `airflow.DagRunType` 
now aliasing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to