FrankYang0529 commented on code in PR #74674:
URL: https://github.com/apache/airflow/pull/74674#discussion_r4438598691
##########
go-sdk/pkg/execution/task_runner.go:
##########
@@ -83,6 +88,9 @@ func RunTask(
LogicalDate: ifaceTimePtr(dagRun.LogicalDate),
DataIntervalStart:
ifaceTimePtr(dagRun.DataIntervalStart),
DataIntervalEnd: ifaceTimePtr(dagRun.DataIntervalEnd),
+ RunAfter: dagRun.RunAfter,
Review Comment:
Should `RunAfter` be in UTC here? msgpack decodes `dagRun.RunAfter` into the
worker's local time zone, and this line copies that value without converting it
to UTC. A Python task gets `dag_run.run_after` in UTC.
#75737, which is still open, converts `LogicalDate`, `DataIntervalStart` and
`DataIntervalEnd` to UTC inside `ifaceTimePtr`. `RunAfter` does not go through
`ifaceTimePtr`, so `RunAfter` would be the only date left in the local time
zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
