ferruzzi commented on code in PR #71850:
URL: https://github.com/apache/airflow/pull/71850#discussion_r4448918690
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -285,9 +295,17 @@ def _recalculate_dagrun_queued_at_deadlines(dagrun:
DagRun, *, session: Session)
try:
decoded_alert = decode_deadline_alert_model(deadline_alert)
interval = resolve_deadline_alert_interval(decoded_alert,
session=session)
- except (ValueError, TypeError):
- # Either step can fail: the alert may hold a payload the decoder
refuses, or a
- # variable-backed interval may point at a Variable that is missing
or non-numeric.
+ new_deadline_time = decoded_alert.reference.evaluate_with(
+ session=session,
+ interval=interval,
+ dagrun=dagrun,
+ dag_id=dagrun.dag_id,
+ run_id=dagrun.run_id,
+ )
+ except Exception:
Review Comment:
I kinda feel we should maybe re-raise a database error, but that's likely
more effort than its worth. I'll approve as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
