dhkim1920 commented on code in PR #73783:
URL: https://github.com/apache/airflow/pull/73783#discussion_r4501806968
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1159,7 +1160,11 @@ def send_msg(
else:
err_resp = self._serialize_response(error) if error else None
frame = _ResponseFrame(id=request_id, error=err_resp)
- self.stdin.sendall(frame.as_bytes())
+ self.stdin.sendall(
+ frame.as_bytes(
+ allow_large_ints=self._supports_large_ints and
self._subprocess_schema_version is None
Review Comment:
You're right that schema versioning does not determine support for the
large-integer extension. I've removed that condition and now gate encoding
solely on supports_large_ints.
I also found that LangSDKDagFileProcessorProcess inherited True from its
parent, so I've explicitly set it to False. External-language task subprocesses
retain their existing False setting.
To clarify why these subclasses override the inherited default, I've added
comments at both declarations explaining that external runtimes do not
implement this MessagePack extension.
Tests verify successful transmission to schema-versioned Python subprocesses
and rejection on external-language paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
