dhkim1920 commented on code in PR #73783:
URL: https://github.com/apache/airflow/pull/73783#discussion_r4538240442
##########
task-sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -177,14 +181,42 @@ def _new_encoder() -> msgspec.msgpack.Encoder:
return msgspec.msgpack.Encoder(enc_hook=_msgpack_enc_hook)
+def _encode_large_ints(value: Any) -> Any:
+ if isinstance(value, int) and not -(2**63) <= value < 2**64:
+ return msgspec.msgpack.Ext(
+ MSGPACK_HUGEINT, value.to_bytes((value.bit_length() + 8) // 8,
"big", signed=True)
+ )
+ if isinstance(value, dict):
+ return {key: _encode_large_ints(item) for key, item in value.items()}
+ if isinstance(value, (list, tuple)):
+ return [_encode_large_ints(item) for item in value]
+ return value
+
+
+def _decode_msgpack_ext(code: int, data: memoryview) -> Any:
+ if code == MSGPACK_HUGEINT:
+ return int.from_bytes(data, "big", signed=True)
+ return msgspec.msgpack.Ext(code, data)
+
+
class _FrameMixin:
_encoder: ClassVar[msgspec.msgpack.Encoder] = _new_encoder()
- def as_bytes(self) -> bytearray:
+ def as_bytes(self, *, allow_large_ints: bool = True) -> bytearray:
# https://jcristharif.com/msgspec/perf-tips.html#length-prefix-framing
for inspiration
buffer = bytearray(256)
- self._encoder.encode_into(self, buffer, 4) # type: ignore[arg-type]
+ try:
+ self._encoder.encode_into(self, buffer, 4) # type:
ignore[arg-type]
+ except OverflowError:
+ if not allow_large_ints:
+ raise
+ # Keep the usual path free of a Python traversal of every message.
+ frame = cast("_RequestFrame | _ResponseFrame", self)
+ fields = {"body": _encode_large_ints(frame.body)}
+ if isinstance(frame, _ResponseFrame):
+ fields["error"] = _encode_large_ints(frame.error)
Review Comment:
Updated as suggested. _RequestFrame declares ("body",) and _ResponseFrame
declares ("body", "error") through _payload_fields, which the shared
serialization code now iterates over. These are ClassVar attributes, so they
are excluded from the wire fields. I also verified that the serialized bytes
match the previous implementation for the comparison cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
