kaxil commented on code in PR #76705:
URL: https://github.com/apache/airflow/pull/76705#discussion_r4586235920


##########
providers/snowflake/pyproject.toml:
##########
@@ -73,15 +73,14 @@ dependencies = [
     # declare no upper bound on cryptography, so an unconstrained resolve 
pairs them with a
     # cryptography they cannot import against. 22.1.0 is the first release 
with a correct bound.
     "pyOpenSSL>=22.1.0",
-    # TODO(potiuk): We should bump the snowflake-connector-python to >=4.0.0 
when sqlalchemy>=2.0 is required
-    # 3.17.0 is the first version with Workload Identity Federation 
(WORKLOAD_IDENTITY authenticator).
     "snowflake-connector-python>=3.17.0",
+    "snowflake-connector-python>=5.1.0; python_version >= '3.14'",

Review Comment:
   This drops Snowpark on 3.14 for anyone who installs it next to the provider. 
The latest Snowpark (1.57.0) still needs `snowflake-connector-python<5`, so 
resolving the 3.14 requirements together with `snowflake-snowpark-python` gives 
Snowpark 1.56.0 on main, and with this floor uv falls back to Snowpark 0.12.0 
(a 2022 release with `requires_python ===3.8.*`). Is that intended? If so, the 
changelog note should say so.



##########
providers/snowflake/docs/changelog.rst:
##########
@@ -27,6 +27,14 @@
 Changelog
 ---------
 
+.. note::

Review Comment:
   This note sits above `6.21.0`, outside any version, so it would stay at the 
top of the changelog for every later release. Could it go under the next 
version instead, or be left for the release manager?



##########
providers/snowflake/pyproject.toml:
##########
@@ -73,15 +73,14 @@ dependencies = [
     # declare no upper bound on cryptography, so an unconstrained resolve 
pairs them with a
     # cryptography they cannot import against. 22.1.0 is the first release 
with a correct bound.
     "pyOpenSSL>=22.1.0",
-    # TODO(potiuk): We should bump the snowflake-connector-python to >=4.0.0 
when sqlalchemy>=2.0 is required
-    # 3.17.0 is the first version with Workload Identity Federation 
(WORKLOAD_IDENTITY authenticator).
     "snowflake-connector-python>=3.17.0",

Review Comment:
   Can we keep the `# 3.17.0 is the first version with Workload Identity 
Federation (WORKLOAD_IDENTITY authenticator).` comment? It's still the reason 
for the `>=3.17.0` floor. Dropping the old TODO is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to