Dev-iL commented on code in PR #76705:
URL: https://github.com/apache/airflow/pull/76705#discussion_r4587005692


##########
providers/snowflake/pyproject.toml:
##########
@@ -73,15 +73,14 @@ dependencies = [
     # declare no upper bound on cryptography, so an unconstrained resolve 
pairs them with a
     # cryptography they cannot import against. 22.1.0 is the first release 
with a correct bound.
     "pyOpenSSL>=22.1.0",
-    # TODO(potiuk): We should bump the snowflake-connector-python to >=4.0.0 
when sqlalchemy>=2.0 is required
-    # 3.17.0 is the first version with Workload Identity Federation 
(WORKLOAD_IDENTITY authenticator).
     "snowflake-connector-python>=3.17.0",

Review Comment:
   Restored the 3.17.0 Workload Identity Federation comment. The obsolete TODO 
stays removed.
   
   ---
   Drafted-by: Codex (GPT-6) (no human review before posting)



##########
providers/snowflake/pyproject.toml:
##########
@@ -73,15 +73,14 @@ dependencies = [
     # declare no upper bound on cryptography, so an unconstrained resolve 
pairs them with a
     # cryptography they cannot import against. 22.1.0 is the first release 
with a correct bound.
     "pyOpenSSL>=22.1.0",
-    # TODO(potiuk): We should bump the snowflake-connector-python to >=4.0.0 
when sqlalchemy>=2.0 is required
-    # 3.17.0 is the first version with Workload Identity Federation 
(WORKLOAD_IDENTITY authenticator).
     "snowflake-connector-python>=3.17.0",
+    "snowflake-connector-python>=5.1.0; python_version >= '3.14'",

Review Comment:
   Yes: the compatible dialect requires connector >=5.1, which conflicts with 
Snowpark 1.57.0's <5 requirement. The Snowpark prerequisites now explicitly 
cover separately installed Snowpark on Python 3.14+ and direct Snowpark 
workflows to Python 3.11–3.13 until a compatible release is available. The PR 
description has the same clarification.
   
   ---
   Drafted-by: Codex (GPT-6) (no human review before posting)



##########
providers/snowflake/docs/changelog.rst:
##########
@@ -27,6 +27,14 @@
 Changelog
 ---------
 
+.. note::

Review Comment:
   6.21.0 was published on November 9, so I removed the unversioned changelog 
note and left placement in the next release to the release manager. The 
compatibility guidance now lives in the Snowpark operator prerequisites.
   
   ---
   Drafted-by: Codex (GPT-6) (no human review before posting)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to