ephraimbuddy commented on code in PR #71214:
URL: https://github.com/apache/airflow/pull/71214#discussion_r4629825215


##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -233,7 +233,7 @@ def readable_config(self):
         keep_last=True,
         keep_last_filters=[column("run_type") != DagRunType.MANUAL],
         keep_last_group_by=["dag_id"],
-        dependent_tables=["task_instance", "task_state_store", "deadline"],
+        dependent_tables=["task_instance", "task_state_store", "deadline", 
"callback"],

Review Comment:
   Callback cleanup skips active states and rows newer than the cutoff, but 
deleting their Dag run still cascades to them without archiving. Please archive 
callbacks using the selected parent IDs and cover active and newer callbacks in 
the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to