fat-catTW commented on code in PR #71214:
URL: https://github.com/apache/airflow/pull/71214#discussion_r4640115585
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -327,9 +327,9 @@ def callback_data_with_context():
elif isinstance(self.callback, ExecutorCallback):
data = callback_data_with_context()
data["deadline_id"] = str(self.id)
- data["dag_run_id"] = str(self.dagrun.id)
data["dag_id"] = self.dagrun.dag_id
Review Comment:
Yes, dropping `data["dag_run_id"]` is intentional because it is now stored
in `callback.dagrun_id`. After the update, the metric tag is preserved by
adding it from that column in `get_metric_info()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]