ashb commented on a change in pull request #7363: [AIRFLOW-6730] Use 
total_seconds instead of seconds
URL: https://github.com/apache/airflow/pull/7363#discussion_r375747056
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/dataproc.py
 ##########
 @@ -618,16 +618,16 @@ def _graceful_decommission_timeout_object(self) -> 
Optional[Dict]:
         match = re.match(r"^(\d+)([smdh])$", 
self.graceful_decommission_timeout)
         if match:
             if match.group(2) == "s":
-                timeout = int(match.group(1))
+                timeout = float(match.group(1))
 
 Review comment:
   The regex is `\d+` so `int()` feels right here
   
   ```suggestion
                   timeout = int(match.group(1))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to