ashb commented on a change in pull request #7363: [AIRFLOW-6730] Use
total_seconds instead of seconds
URL: https://github.com/apache/airflow/pull/7363#discussion_r375748282
##########
File path: airflow/providers/google/cloud/operators/postgres_to_gcs.py
##########
@@ -94,7 +94,7 @@ def convert_type(self, value, schema_type):
return datetime.timedelta(
hours=formated_time.tm_hour,
minutes=formated_time.tm_min,
- seconds=formated_time.tm_sec).seconds
+ seconds=formated_time.tm_sec).total_seconds()
Review comment:
```
In [7]: timedelta(hours=12, minutes=30, seconds=30).seconds
Out[7]: 45030
In [8]: timedelta(hours=12, minutes=30, seconds=30).total_seconds()
Out[8]: 45030.0
```
(total_seconds returns a float, previously this was an int. I don't think
that is intended.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
