feluelle commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks
should cache boto3 client
URL: https://github.com/apache/airflow/pull/7541#discussion_r384466443
##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -232,6 +243,23 @@ def get_resource_type(self, resource_type,
region_name=None, config=None):
resource_type, endpoint_url=endpoint_url, config=config,
verify=self.verify
)
+ @cached_property
+ def conn(self):
+ "Get the underlying boto3 client (cached)"
Review comment:
Would be great if you could also add a type hint for the return value.
Either in the description or the function header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
