baolsen commented on a change in pull request #7541: [AIRFLOW-6822] AWS hooks 
should cache boto3 client
URL: https://github.com/apache/airflow/pull/7541#discussion_r385061503
 
 

 ##########
 File path: airflow/providers/amazon/aws/hooks/base_aws.py
 ##########
 @@ -49,9 +50,19 @@ class AwsBaseHook(BaseHook):
     :type verify: str or bool
     """
 
-    def __init__(self, aws_conn_id="aws_default", verify=None):
+    def __init__(
+            self,
+            aws_conn_id="aws_default",
+            verify=None,
+            region_name=None,
+            client_type=None,
+            resource_type=None
 
 Review comment:
   @feluelle Thanks for the feedback, please take another look. I've updated 
the docstrings on all the hooks accordingly. There's only a "how to" document 
for the DataSync operator, no other separate docs for AWS - at least that I 
could see. Let me know if there's anywhere else you can think of :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to