[ https://issues.apache.org/jira/browse/AIRFLOW-6399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068099#comment-17068099 ]
ASF GitHub Bot commented on AIRFLOW-6399: ----------------------------------------- kaxil commented on pull request #7896: [AIRFLOW-6399] Validate _access control in deserialized DAGs URL: https://github.com/apache/airflow/pull/7896 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Serialization: DAG access_control field should be decorated field in DAG > serialization > -------------------------------------------------------------------------------------- > > Key: AIRFLOW-6399 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6399 > Project: Apache Airflow > Issue Type: Bug > Components: DAG, scheduler, webserver > Affects Versions: 1.10.7, 1.10.8 > Reporter: Xich Long Le > Assignee: Xich Long Le > Priority: Major > Fix For: 1.10.10 > > > When DAG serialization is enabled, if any DAG contain field: "access_control": > - Scheduler will fail to schedule all jobs. > - Webserver cannot browse those DAG with "access_control" > Scheduler output: > ValidationError: Additional properties are not allowed ('_access_control' was > unexpected) > Failed validating u'additionalProperties' in > schema[u'allOf'][0][u'properties'][u'dag'] > Reason: > [https://github.com/apache/airflow/blob/1.10.7/airflow/serialization/schema.json|https://github.com/apache/airflow/blob/1.10.7/airflow/serialization/schema.json] > does not have access_control as a whitelisted field. > AIRFLOW-6425 added '_access_control' to JSON schema but does not define it as > decorated_fields making the field to serialized/deserialized incorrectly. -- This message was sent by Atlassian Jira (v8.3.4#803005)