ShawonC opened a new issue #8036: SalesforceHook not compatible with 
simple_salesforce 1.0.0
URL: https://github.com/apache/airflow/issues/8036
 
 
   **Apache Airflow version**: 1.10.9
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl 
version`): 1.17.0
   
   **Environment**: production
   
   - **Cloud provider or hardware configuration**: GKE
   - **OS** (e.g. from /etc/os-release): Debian GNU/Linux 9 (stretch)
   - **Kernel** (e.g. `uname -a`): Linux 0 4.14.138+ #1 SMP Tue Sep 3 02:58:08 
PDT 2019 x86_64 GNU/Linux
   - **Install tools**: pip
   - **Others**: helm
   **What happened**:
   
   When running out salesforce dag, which uses a custom hook that wraps the 
base hook, the base hook gives us the following error:
   
   
   **What you expected to happen**:
   
   I expected the base SalesforceHook() class to properly sign in and pull 
data. It seems that this issue started occurring with the latest release of 
simple_salesforce, version 1.0.0.
   
   <!-- What do you think went wrong? -->
   
   Based on the simple_salesforce code, it looks like the sign_in method in the 
SalesforceHook class in airflow/contrib/salesforce/hooks/salesforce_hook.py is 
still calling a deprecated keyword argument of `sandbox`. 
   
   Here is a link to the commit for simple_salesforce 1.0.0 12 days ago: 
https://github.com/simple-salesforce/simple-salesforce/commit/1ebee0085b27ab5f9181a5e691fb8dc9fdc90163
   
   **How to reproduce it**:
   <!---
   
   Try to use the SalesforceHook in a dag that installed apache-airflow 1.10.9 
via pip. I am using the stable/airflow helm chart with the 
puckel/docker-airflow docker image.
   
   --->
   
   
   <!--
   
   Everytime the SalesforceHook class tries to sign in with the Salesforce 
credentials
   
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to