mik-laj commented on a change in pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#discussion_r446087927
##########
File path: airflow/www/views.py
##########
@@ -1493,8 +1505,14 @@ def recurse_nodes(task, visited):
form = DateTimeWithNumRunsForm(data={'base_date': max_date,
'num_runs': num_runs})
- external_logs = conf.get('elasticsearch', 'frontend')
+
doc_md = wwwutils.wrapped_markdown(getattr(dag, 'doc_md', None),
css_class='dag-doc')
+
+ task_log_reader = TaskLogReader()
+ handler = task_log_reader.log_handler
+ show_external_log_redirect = isinstance(handler, ExternalLoggingMixin)
Review comment:
Can you create a property from this condition in TaskLogReader? In
general, all logic should be outside the view method. The view should only
format the responses to the expected format. I know that this code does not
look like this at the moment, but I am trying to fix it so that the Web UI is
not just one file, but it is a more manageable code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
