mik-laj commented on a change in pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#discussion_r446610398
##########
File path: airflow/utils/log/log_reader.py
##########
@@ -100,6 +101,11 @@ def is_supported(self):
return hasattr(self.log_handler, 'read')
+ @property
+ def is_external(self):
+ """Check if the logging handler is external (e.g. Elasticsearch,
Stackdriver, etc)."""
Review comment:
```suggestion
def supports_external_link(self):
"""Check if the logging handler is external links (e.g.
Elasticsearch, Stackdriver, etc)."""
```
This name is because the word "external" suggests that the class is not part
of the Airflow core, but we want to check here whether external links are
supported. When we introduce it, we need to improve the "A" property so that
it has a similar naming convention - `support_read`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
