Jzjsnow commented on code in PR #3639:
URL: https://github.com/apache/amoro/pull/3639#discussion_r2189906618
##########
amoro-optimizer/amoro-optimizer-common/src/main/java/org/apache/amoro/optimizer/common/OptimizerExecutor.java:
##########
@@ -50,8 +50,28 @@ public void start() {
try {
OptimizingTask task = pollTask();
if (task != null && ackTask(task)) {
- OptimizingTaskResult result = executeTask(task);
Review Comment:
I remove the additional try-catch block in the new commit, and reuse the
original try-catch block. The `completeTask(result)` method is now placed in
the finally block to ensure that the task can complete in ams as long as the
task is successfully acknowledged, regardless of whether an exception occurs
during execution. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
