klion26 commented on code in PR #3639:
URL: https://github.com/apache/amoro/pull/3639#discussion_r2213005483
##########
amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java:
##########
@@ -241,10 +241,11 @@ public void ackTask(String authToken, int threadId,
OptimizingTaskId taskId) {
@Override
public void completeTask(String authToken, OptimizingTaskResult taskResult) {
LOG.info(
- "Optimizer {} (threadId {}) complete task {}",
+ "Optimizer {} (threadId {}) complete task {} (status: {})",
authToken,
taskResult.getThreadId(),
- taskResult.getTaskId());
+ taskResult.getTaskId(),
+ taskResult.getErrorMessage() == null ? "SUCCESS" : "FAIL");
Review Comment:
nit: we may reuse `TaskRuntime.Status.SUCCESS` and
`TaskRuntime.Status.FAILED` instead of hard coding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
