klion26 commented on code in PR #3659:
URL: https://github.com/apache/amoro/pull/3659#discussion_r2212827197
##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/DanglingDeleteFilesCleaningExecutor.java:
##########
@@ -55,6 +57,11 @@ public void handleConfigChanged(
scheduleIfNecessary(tableRuntime, getStartDelay());
}
+ @Override
+ protected long getExecutorDelay() {
+ return ThreadLocalRandom.current().nextLong(INTERVAL / 2);
Review Comment:
Why do we need to to set th range to `INTERVAL / 2`
##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/DanglingDeleteFilesCleaningExecutor.java:
##########
@@ -41,7 +43,7 @@ protected DanglingDeleteFilesCleaningExecutor(TableService
tableService, int poo
@Override
protected long getNextExecutingTime(DefaultTableRuntime tableRuntime) {
- return INTERVAL;
+ return INTERVAL + getExecutorDelay();
Review Comment:
Since we have changed the `getStartDelay` to trigger the tables randomly
every time, why do we need this change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
