zhangwl9 commented on code in PR #3659:
URL: https://github.com/apache/amoro/pull/3659#discussion_r2221576188
##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/DanglingDeleteFilesCleaningExecutor.java:
##########
@@ -55,6 +57,11 @@ public void handleConfigChanged(
scheduleIfNecessary(tableRuntime, getStartDelay());
}
+ @Override
+ protected long getExecutorDelay() {
+ return ThreadLocalRandom.current().nextLong(INTERVAL / 2);
Review Comment:
@klion26 Because the default value of Interval is 1d, if the random range
is [1d,2d], when interval=2d, the execution interval of executor is too long,
and when there is a lot of cleanup data, it will lead to low execution
frequency (2d once) and long execution time. Therefore, choose [1d,1.5d] to
ensure that the trigger timing of executor is randomized and the execution
interval is not too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
