klion26 commented on code in PR #3678:
URL: https://github.com/apache/amoro/pull/3678#discussion_r2224845768
##########
amoro-ams/src/main/java/org/apache/amoro/server/catalog/CatalogBuilder.java:
##########
@@ -90,9 +90,11 @@ public static ServerCatalog buildServerCatalog(
case CATALOG_TYPE_HIVE:
String amsUri = getAmsURI(serverConfiguration);
catalogMeta.getCatalogProperties().put(CatalogMetaProperties.AMS_URI,
amsUri);
- catalogMeta
- .getCatalogProperties()
- .put(CLIENT_POOL_SIZE, String.valueOf(CLIENT_POOL_SIZE_DEFAULT));
+ if (!catalogMeta.getCatalogProperties().containsKey(CLIENT_POOL_SIZE))
{
Review Comment:
If the logic here overrides the value user set, does that mean we can safely
remove this logic here?
##########
amoro-ams/src/main/java/org/apache/amoro/server/catalog/CatalogBuilder.java:
##########
@@ -90,9 +90,11 @@ public static ServerCatalog buildServerCatalog(
case CATALOG_TYPE_HIVE:
String amsUri = getAmsURI(serverConfiguration);
catalogMeta.getCatalogProperties().put(CatalogMetaProperties.AMS_URI,
amsUri);
- catalogMeta
- .getCatalogProperties()
- .put(CLIENT_POOL_SIZE, String.valueOf(CLIENT_POOL_SIZE_DEFAULT));
+ if (!catalogMeta.getCatalogProperties().containsKey(CLIENT_POOL_SIZE))
{
Review Comment:
If the logic here overrides the value the user set, does that mean we can
safely remove this logic here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
