MarigWeizhi commented on PR #3678:
URL: https://github.com/apache/amoro/pull/3678#issuecomment-3133217621
@klion26 Thank you for your reply.
I think these three lines of code `CatalogBuilder.java (lines 93–95)` is to
allow users to see the default value of `clients` in the Web UI even when it is
not explicitly set, making it easier to view and modify.
I tested two case after removing these three lines in `CatalogBuilder.java`
(lines 93–95):
1. **When creating a catalog without configuring `clients`**:
- The catalog does **not** include the `clients` parameter.
- As a result, the `clients` field is **not visible** in the Web UI.
- Eventually, the default value of `20` is used at runtime, as defined
here:
[CachedHiveClientPool.java#L54](https://github.com/apache/amoro/blob/master/amoro-common/src/main/java/org/apache/amoro/hive/CachedHiveClientPool.java#L54)
2. **When creating a catalog with `clients=15`**:
- The catalog correctly uses the configured value of `15`.
- The `clients` parameter is displayed and editable in the Web UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
