klion26 commented on code in PR #3696:
URL: https://github.com/apache/amoro/pull/3696#discussion_r2241609061
##########
dist/src/main/amoro-bin/conf/log4j2.xml:
##########
@@ -114,6 +114,14 @@
<AppenderRef ref="consoleAppender" level="${CONSOLE_LEVEL}"/>
</logger>
+ <logger name="org.apache.iceberg.BaseMetastoreCatalog" level="debug"/>
Review Comment:
Why do we need to change this?
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingQueue.java:
##########
@@ -269,13 +269,12 @@ private void triggerAsyncPlanning(
.map(item -> item + "")
.collect(Collectors.joining(","));
LOG.info(
- "Completed planning on table {} with {} tasks with a
total cost of {} ms, skipping {} tables,"
- + " id list:{}",
+ "Completed planning on table {} with {} tasks with a
total cost of {} ms, skipping {} tables",
Review Comment:
Could we change this to
```
if (LOG.isDebugEnabled()) {
LOG.info() // only the needed log
} else {
LOG.debug() // with all log
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
