zhoujinsong commented on code in PR #3696:
URL: https://github.com/apache/amoro/pull/3696#discussion_r2247276689
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/KeyedTableCommit.java:
##########
@@ -141,10 +145,14 @@ public void commit() throws OptimizingCommitException {
try {
executeCommit(addedDataFiles, removedDataFiles, addedDeleteFiles,
removedDeleteFiles);
- LOG.info("Successfully commit table {} with {} tasks", table.id(),
tasks.size());
+ LOG.info(
+ "Table {} committed {} tasks successfully in {} ms.",
+ table.id(),
+ tasks.size(),
+ System.currentTimeMillis() - startTime);
} catch (Exception e) {
// Only failures to clean files will trigger a retry
- LOG.warn("Optimize commit table {} failed, give up commit.", table.id(),
e);
+ LOG.warn("Failed to commit table {}. Aborting commit.", table.id(), e);
Review Comment:
```suggestion
LOG.warn("Failed to commit table {}. ", table.id(), e);
```
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/UnKeyedTableCommit.java:
##########
@@ -231,12 +232,16 @@ public void commit() throws OptimizingCommitException {
transaction, removedDataFiles, addedDataFiles, removedDeleteFiles,
addedDeleteFiles);
}
transaction.commitTransaction();
- LOG.info("Successfully commit table {} with {} tasks", table.id(),
tasks.size());
+ LOG.info(
+ "Table {} committed {} tasks successfully in {} ms.",
+ table.id(),
+ tasks.size(),
+ System.currentTimeMillis() - startTime);
} catch (Exception e) {
if (needMoveFile2Hive()) {
correctHiveData(addedDataFiles, addedDeleteFiles);
}
- LOG.warn("Optimize commit table {} failed, give up commit.", table.id(),
e);
+ LOG.warn("Failed to commit table {}. Aborting commit.", table.id(), e);
Review Comment:
```suggestion
LOG.warn("Failed to commit table {}. ", table.id(), e);
```
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/KeyedTableCommit.java:
##########
@@ -141,10 +145,14 @@ public void commit() throws OptimizingCommitException {
try {
executeCommit(addedDataFiles, removedDataFiles, addedDeleteFiles,
removedDeleteFiles);
- LOG.info("Successfully commit table {} with {} tasks", table.id(),
tasks.size());
+ LOG.info(
+ "Table {} committed {} tasks successfully in {} ms.",
Review Comment:
```suggestion
"Successfully committed {} table in {} ms.",
```
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/UnKeyedTableCommit.java:
##########
@@ -231,12 +232,16 @@ public void commit() throws OptimizingCommitException {
transaction, removedDataFiles, addedDataFiles, removedDeleteFiles,
addedDeleteFiles);
}
transaction.commitTransaction();
- LOG.info("Successfully commit table {} with {} tasks", table.id(),
tasks.size());
+ LOG.info(
+ "Table {} committed {} tasks successfully in {} ms.",
Review Comment:
```suggestion
""Successfully committed {} table in {} ms."",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
