cxxiii commented on code in PR #3675:
URL: https://github.com/apache/amoro/pull/3675#discussion_r2259388516
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingProcess.java:
##########
@@ -44,7 +44,11 @@ public interface OptimizingProcess {
long getRunningQuotaTime(long calculatingStartTime, long calculatingEndTime);
+ boolean containSuccessTasks();
+
void commit();
+ void commitClosedProcess();
Review Comment:
Your suggestion is good, I have made changes.
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingQueue.java:
##########
@@ -507,14 +507,32 @@ private void acceptResult(TaskRuntime<?> taskRuntime) {
taskRuntime.getFailReason());
retryTask(taskRuntime);
} else {
- LOG.info(
- "Task {} has reached the max execute retry count. Process {}
failed.",
- taskRuntime.getTaskId(),
- processId);
- this.failedReason = taskRuntime.getFailReason();
- this.status = ProcessStatus.FAILED;
- this.endTime = taskRuntime.getEndTime();
- persistAndSetCompleted(false);
+ try {
+ buildCommit().commit();
Review Comment:
Your suggestion is good, I have made changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
