zhoujinsong commented on code in PR #3675:
URL: https://github.com/apache/amoro/pull/3675#discussion_r2299908588
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/UnKeyedTableCommit.java:
##########
@@ -245,6 +256,17 @@ public void commit() throws OptimizingCommitException {
}
}
+ private boolean needRemove(
Review Comment:
Perhaps we should proactively identify the delete files that need to be
excluded in advance, rather than iterate through the task map each time to
improve efficiency.
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/table/TableProperties.java:
##########
@@ -72,6 +72,10 @@ private TableProperties() {}
public static final boolean ENABLE_SELF_OPTIMIZING_DEFAULT = true;
+ public static final String SELF_OPTIMIZING_COMMIT_ON_PARTIAL_SUCCESS =
+ "self-optimizing.commit-on-partial-success";
+ public static final boolean
SELF_OPTIMIZING_COMMIT_ON_PARTIAL_SUCCESS_DEFAULT = true;
Review Comment:
I suggest making the default value false , as it is a new feature.
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/table/TableProperties.java:
##########
@@ -72,6 +72,10 @@ private TableProperties() {}
public static final boolean ENABLE_SELF_OPTIMIZING_DEFAULT = true;
+ public static final String SELF_OPTIMIZING_COMMIT_ON_PARTIAL_SUCCESS =
+ "self-optimizing.commit-on-partial-success";
+ public static final boolean
SELF_OPTIMIZING_COMMIT_ON_PARTIAL_SUCCESS_DEFAULT = true;
Review Comment:
And is `self-optimizing.allow-partial-commit` a proper name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
