zhoujinsong commented on PR #4161: URL: https://github.com/apache/amoro/pull/4161#issuecomment-4174245823
Thanks for the PR! One question on the config design: is there a specific reason to have two separate keep-time parameters (`self-optimizing.runtime-data-keep-time` and `process.history-data-keep-time`)? Since `table_process` already gets cleaned by `keepTime` anyway (step 1 deletes everything older than 30d), the `processKeepTime` only adds an earlier cleanup for terminal records. If the data volume of `table_process` is not a concern, we could simplify this to a single `runtime-data-keep-time` parameter and avoid the cognitive overhead of having users understand the distinction between the two. Could you share the motivation for keeping them separate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
