zhoujinsong commented on PR #4161: URL: https://github.com/apache/amoro/pull/4161#issuecomment-4174246168
There's a potential data leak issue: the cleanup in `ProcessDataExpiringExecutor` is driven per `TableRuntime`. If a table is dropped, its `TableRuntime` is removed and the executor will never process it again — leaving orphaned records in `table_process` (and related tables) that will never be cleaned up. `PeriodicTableScheduler.handleTableRemoved()` currently does nothing, so there's no trigger to clean up process history on table drop. This doesn't need to block this PR, but worth tracking as a follow-up: either hook into `handleTableRemoved` to do a one-shot cleanup, or add a periodic global scan that deletes records for table IDs no longer in `table_metadata`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
