[arrow] branch master updated: ARROW-2095: [C++] Less verbose building 3rd party deps

[uwe]

This is an automated email from the ASF dual-hosted git repository.

uwe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new bd1e6e5  ARROW-2095: [C++] Less verbose building 3rd party deps
bd1e6e5 is described below

commit bd1e6e58d489b965a76d7f548042052a15c5fc2a
Author: Antoine Pitrou <anto...@python.org>
AuthorDate: Wed Feb 7 16:28:59 2018 +0100

    ARROW-2095: [C++] Less verbose building 3rd party deps
    
    Also fixes ARROW-2096.
    
    Author: Antoine Pitrou <anto...@python.org>
    
    Closes #1569 from pitrou/ARROW-2095-less-verbose-cpp-build and squashes the 
following commits:
    
    1c8bf1e [Antoine Pitrou] ARROW-2095: [C++] Less verbose building 3rd party 
deps
---
 cpp/CMakeLists.txt                          |  2 +-
 cpp/cmake_modules/ThirdpartyToolchain.cmake | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index f07ef6b..0734712 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -205,7 +205,7 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL 
"${CMAKE_CURRENT_SOURCE_DIR}")
 
   option(ARROW_VERBOSE_THIRDPARTY_BUILD
     "If off, output from ExternalProjects will be logged to files rather than 
shown"
-    ON)
+    OFF)
 
   if (MSVC)
     set(BROTLI_MSVC_STATIC_LIB_SUFFIX "-static" CACHE STRING
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake 
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 374c652..193b162 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -44,8 +44,10 @@ if (NOT ARROW_VERBOSE_THIRDPARTY_BUILD)
     LOG_BUILD 1
     LOG_INSTALL 1
     LOG_DOWNLOAD 1)
+  set(Boost_DEBUG FALSE)
 else()
   set(EP_LOG_OPTIONS)
+  set(Boost_DEBUG TRUE)
 endif()
 
 if (NOT MSVC)
@@ -130,7 +132,6 @@ endif()
 # ----------------------------------------------------------------------
 # Add Boost dependencies (code adapted from Apache Kudu (incubating))
 
-set(Boost_DEBUG TRUE)
 set(Boost_USE_MULTITHREADED ON)
 if (MSVC AND ARROW_USE_STATIC_CRT)
   set(Boost_USE_STATIC_RUNTIME ON)
@@ -849,7 +850,8 @@ if (ARROW_WITH_GRPC)
       BUILD_BYPRODUCTS "${GRPC_STATIC_LIBRARY_GPR}" 
"${GRPC_STATIC_LIBRARY_GRPC}" "${GRPC_STATIC_LIBRARY_GRPCPP}"
       ${GRPC_BUILD_BYPRODUCTS}
       ${EP_LOG_OPTIONS}
-      CMAKE_ARGS ${GRPC_CMAKE_ARGS})
+      CMAKE_ARGS ${GRPC_CMAKE_ARGS}
+      ${EP_LOG_OPTIONS})
   else()
     find_package(gRPC CONFIG REQUIRED)
     set(GRPC_VENDORED 0)
@@ -884,11 +886,8 @@ if (ARROW_ORC)
       CONFIGURE_COMMAND "./configure" "--disable-shared" 
"--prefix=${PROTOBUF_PREFIX}" "CXXFLAGS=${EP_CXX_FLAGS}"
       BUILD_IN_SOURCE 1
       URL ${PROTOBUF_SRC_URL}
-      LOG_DOWNLOAD 1
-      LOG_CONFIGURE 1
-      LOG_BUILD 1
-      LOG_INSTALL 1
-      BUILD_BYPRODUCTS "${PROTOBUF_STATIC_LIB}")
+      BUILD_BYPRODUCTS "${PROTOBUF_STATIC_LIB}"
+      ${EP_LOG_OPTIONS})
 
     set (PROTOBUF_VENDORED 1)
   else ()
@@ -930,7 +929,8 @@ if (ARROW_ORC)
   ExternalProject_Add(orc_ep
     URL "https://github.com/apache/orc/archive/${ORC_VERSION}.tar.gz";
     BUILD_BYPRODUCTS ${ORC_STATIC_LIB}
-    CMAKE_ARGS ${ORC_CMAKE_ARGS})
+    CMAKE_ARGS ${ORC_CMAKE_ARGS}
+    ${EP_LOG_OPTIONS})
 
   include_directories(SYSTEM ${ORC_INCLUDE_DIR})
   ADD_THIRDPARTY_LIB(orc

-- 
To stop receiving notification emails like this one, please contact
u...@apache.org.