This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 90bb4bd ARROW-2111: [C++] Lint in parallel
90bb4bd is described below
commit 90bb4bdb53486f2d86b3bd8d7105a15c7731d942
Author: Antoine Pitrou <[email protected]>
AuthorDate: Wed Feb 7 15:01:11 2018 -0500
ARROW-2111: [C++] Lint in parallel
On my 4-core machine this cuts `make lint` down from 24s. to 8s.
Note the `-P` option to `xargs` is not POSIX, though it seems supported on
OS X (and of course on GNU). Not sure we are ok with this.
Author: Antoine Pitrou <[email protected]>
Closes #1573 from pitrou/ARROW-2111-parallel-lint and squashes the
following commits:
246bd6da [Antoine Pitrou] ARROW-2111: [C++] Lint in parallel
---
cpp/CMakeLists.txt | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 0734712..62c8e65 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -455,11 +455,14 @@ if (UNIX)
message(STATUS "Found cpplint executable at ${CPPLINT_BIN}")
# Full lint
- add_custom_target(lint ${CPPLINT_BIN}
+ # Balancing act: cpplint.py takes a non-trivial time to launch,
+ # so process 12 files per invocation, while still ensuring parallelism
+ add_custom_target(lint echo ${FILTERED_LINT_FILES} | xargs -n12 -P8
+ ${CPPLINT_BIN}
--verbose=2
--linelength=90
--filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order
- ${FILTERED_LINT_FILES})
+ )
endif (UNIX)
--
To stop receiving notification emails like this one, please contact
[email protected].
