weiqingy commented on code in PR #2063: URL: https://github.com/apache/auron/pull/2063#discussion_r2903163008
########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/vectors/ArrowDoubleColumnVector.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.vectors; + +import org.apache.arrow.vector.Float8Vector; +import org.apache.flink.table.data.columnar.vector.DoubleColumnVector; +import org.apache.flink.util.Preconditions; + +/** + * A Flink {@link DoubleColumnVector} backed by an Arrow {@link Float8Vector}. + * + * <p>This wrapper delegates all reads to the underlying Arrow vector, providing zero-copy access + * to Arrow data from Flink's columnar batch execution engine. + */ +public final class ArrowDoubleColumnVector implements DoubleColumnVector { + + private Float8Vector vector; + + /** + * Creates a new wrapper around the given Arrow {@link Float8Vector}. + * + * @param vector the Arrow vector to wrap, must not be null + */ + public ArrowDoubleColumnVector(Float8Vector vector) { + this.vector = Preconditions.checkNotNull(vector); + } + + /** {@inheritDoc} */ + @Override + public boolean isNullAt(int i) { + return vector.isNull(i); + } + + /** {@inheritDoc} */ + @Override + public double getDouble(int i) { + return vector.get(i); + } + + /** + * Replaces the underlying Arrow vector. Used during reader reset to point at a new batch + * without allocating a new wrapper. + * + * @param vector the new Arrow vector, must not be null + */ + void setVector(Float8Vector vector) { Review Comment: Done. ########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/vectors/ArrowFloatColumnVector.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.vectors; + +import org.apache.arrow.vector.Float4Vector; +import org.apache.flink.table.data.columnar.vector.FloatColumnVector; +import org.apache.flink.util.Preconditions; + +/** + * A Flink {@link FloatColumnVector} backed by an Arrow {@link Float4Vector}. + * + * <p>This wrapper delegates all reads to the underlying Arrow vector, providing zero-copy access + * to Arrow data from Flink's columnar batch execution engine. + */ +public final class ArrowFloatColumnVector implements FloatColumnVector { + + private Float4Vector vector; + + /** + * Creates a new wrapper around the given Arrow {@link Float4Vector}. + * + * @param vector the Arrow vector to wrap, must not be null + */ + public ArrowFloatColumnVector(Float4Vector vector) { + this.vector = Preconditions.checkNotNull(vector); + } + + /** {@inheritDoc} */ + @Override + public boolean isNullAt(int i) { + return vector.isNull(i); + } + + /** {@inheritDoc} */ + @Override + public float getFloat(int i) { + return vector.get(i); + } + + /** + * Replaces the underlying Arrow vector. Used during reader reset to point at a new batch + * without allocating a new wrapper. + * + * @param vector the new Arrow vector, must not be null + */ + void setVector(Float4Vector vector) { Review Comment: Done. ########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/vectors/ArrowIntColumnVector.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.vectors; + +import org.apache.arrow.vector.IntVector; +import org.apache.flink.table.data.columnar.vector.IntColumnVector; +import org.apache.flink.util.Preconditions; + +/** + * A Flink {@link IntColumnVector} backed by an Arrow {@link IntVector}. + * + * <p>This wrapper delegates all reads to the underlying Arrow vector, providing zero-copy access + * to Arrow data from Flink's columnar batch execution engine. + */ +public final class ArrowIntColumnVector implements IntColumnVector { + + private IntVector vector; + + /** + * Creates a new wrapper around the given Arrow {@link IntVector}. + * + * @param vector the Arrow vector to wrap, must not be null + */ + public ArrowIntColumnVector(IntVector vector) { + this.vector = Preconditions.checkNotNull(vector); + } + + /** {@inheritDoc} */ + @Override + public boolean isNullAt(int i) { + return vector.isNull(i); + } + + /** {@inheritDoc} */ + @Override + public int getInt(int i) { + return vector.get(i); + } + + /** + * Replaces the underlying Arrow vector. Used during reader reset to point at a new batch + * without allocating a new wrapper. + * + * @param vector the new Arrow vector, must not be null + */ + void setVector(IntVector vector) { Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
