weiqingy commented on code in PR #2063: URL: https://github.com/apache/auron/pull/2063#discussion_r2903164562
########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/vectors/ArrowDecimalColumnVector.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.vectors; + +import org.apache.arrow.memory.ArrowBuf; +import org.apache.arrow.vector.DecimalVector; +import org.apache.flink.table.data.DecimalData; +import org.apache.flink.table.data.columnar.vector.DecimalColumnVector; +import org.apache.flink.util.Preconditions; + +/** + * A Flink {@link DecimalColumnVector} backed by an Arrow {@link DecimalVector}. + * + * <p>This wrapper delegates all reads to the underlying Arrow vector, providing zero-copy access + * to Arrow data from Flink's columnar batch execution engine. + * + * <p>For compact decimals (precision <= 18), the implementation avoids BigDecimal allocation by + * reading the unscaled value directly from Arrow's little-endian byte representation. + */ +public final class ArrowDecimalColumnVector implements DecimalColumnVector { + + /** + * Maximum precision that fits in a long (same as Flink's internal compact decimal threshold). + * DecimalData.MAX_COMPACT_PRECISION is package-private, so we define our own constant. + */ + private static final int MAX_COMPACT_PRECISION = 18; + + private DecimalVector vector; + + /** + * Creates a new wrapper around the given Arrow {@link DecimalVector}. + * + * @param vector the Arrow vector to wrap, must not be null + */ + public ArrowDecimalColumnVector(DecimalVector vector) { + this.vector = Preconditions.checkNotNull(vector); + } + + /** {@inheritDoc} */ + @Override + public boolean isNullAt(int i) { + return vector.isNull(i); + } + + /** {@inheritDoc} */ + @Override + public DecimalData getDecimal(int i, int precision, int scale) { + if (precision <= MAX_COMPACT_PRECISION) { Review Comment: Sounds good — keeping the Decimal implementation as-is. We'll validate it with round-trip tests once the writer PR (#1930) merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
