This is an automated email from the ASF dual-hosted git repository. blachniet pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/avro.git
commit eef00d72cc172896980e515bee1a84fa3a29aa3a Author: Brian Lachniet <[email protected]> AuthorDate: Sun Aug 18 15:27:54 2019 -0400 AVRO-2454: Fix SA1610 - PropertyDocumentationMustHaveValueText --- lang/csharp/Avro.ruleset | 1 - lang/csharp/src/apache/main/Reflect/ArrayHelper.cs | 3 --- lang/csharp/src/apache/main/Reflect/AvroFieldAttribute.cs | 2 -- lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs | 2 -- lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs | 1 - lang/csharp/src/apache/main/Reflect/ReflectReader.cs | 1 - lang/csharp/src/apache/main/Reflect/ReflectWriter.cs | 2 -- 7 files changed, 12 deletions(-) diff --git a/lang/csharp/Avro.ruleset b/lang/csharp/Avro.ruleset index 221d03c..a624c32 100644 --- a/lang/csharp/Avro.ruleset +++ b/lang/csharp/Avro.ruleset @@ -133,7 +133,6 @@ <Rule Id="SA1516" Action="Info" /> <Rule Id="SA1519" Action="Info" /> <Rule Id="SA1520" Action="Info" /> - <Rule Id="SA1610" Action="Info" /> <Rule Id="SA1611" Action="Info" /> <Rule Id="SA1614" Action="Info" /> <Rule Id="SA1615" Action="Info" /> diff --git a/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs b/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs index 5cd1437..afc6467 100644 --- a/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs +++ b/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs @@ -34,7 +34,6 @@ namespace Avro.Reflect /// <summary> /// Collection type to apply by default to all array objects. If not set this defaults to a generic List. /// </summary> - /// <value></value> public static Type DefaultType { get => _defaultType; @@ -44,7 +43,6 @@ namespace Avro.Reflect /// <summary> /// The array /// </summary> - /// <value></value> public IEnumerable Enumerable { get; set; } /// <summary> @@ -80,7 +78,6 @@ namespace Avro.Reflect /// <summary> /// Type of the array to create when deserializing /// </summary> - /// <value></value> public virtual Type ArrayType { get => _defaultType; diff --git a/lang/csharp/src/apache/main/Reflect/AvroFieldAttribute.cs b/lang/csharp/src/apache/main/Reflect/AvroFieldAttribute.cs index ccf56b1..5aa214a 100644 --- a/lang/csharp/src/apache/main/Reflect/AvroFieldAttribute.cs +++ b/lang/csharp/src/apache/main/Reflect/AvroFieldAttribute.cs @@ -30,13 +30,11 @@ namespace Avro.Reflect /// <summary> /// Name of the field in the Avro Schema /// </summary> - /// <value></value> public string FieldName { get; set; } /// <summary> /// Convert the property into a standard Avro type - e.g. DateTimeOffset to long /// </summary> - /// <value></value> public IAvroFieldConverter Converter { get; set; } /// <summary> diff --git a/lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs b/lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs index 32a626b..676d9f3 100644 --- a/lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs +++ b/lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs @@ -35,7 +35,6 @@ namespace Avro.Reflect /// C# type to create when deserializing a map. Must implement IDictionary<,> and the first /// type parameter must be a string. Default is System.Collections.Generic.Dictionary /// </summary> - /// <value></value> public Type MapType { get => _mapType; set => _mapType = value; } private ClassCache _classCache = new ClassCache(); @@ -43,7 +42,6 @@ namespace Avro.Reflect /// <summary> /// Class cache /// </summary> - /// <value></value> public ClassCache ClassCache { get => _classCache; } private Type _mapType = typeof(Dictionary<,>); diff --git a/lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs b/lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs index 02d2748..a6397c6 100644 --- a/lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs +++ b/lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs @@ -33,7 +33,6 @@ namespace Avro.Reflect /// <summary> /// Class cache /// </summary> - /// <value></value> public ClassCache ClassCache { get => _classCache; } /// <summary> diff --git a/lang/csharp/src/apache/main/Reflect/ReflectReader.cs b/lang/csharp/src/apache/main/Reflect/ReflectReader.cs index 5a08ac4..0c2df58 100644 --- a/lang/csharp/src/apache/main/Reflect/ReflectReader.cs +++ b/lang/csharp/src/apache/main/Reflect/ReflectReader.cs @@ -35,7 +35,6 @@ namespace Avro.Reflect /// <summary> /// Default reader /// </summary> - /// <value></value> public ReflectDefaultReader Reader { get => _reader; } /// <summary> diff --git a/lang/csharp/src/apache/main/Reflect/ReflectWriter.cs b/lang/csharp/src/apache/main/Reflect/ReflectWriter.cs index 829c204..51b96ce 100644 --- a/lang/csharp/src/apache/main/Reflect/ReflectWriter.cs +++ b/lang/csharp/src/apache/main/Reflect/ReflectWriter.cs @@ -30,7 +30,6 @@ namespace Avro.Reflect /// <summary> /// Default writer /// </summary> - /// <value></value> public ReflectDefaultWriter Writer { get => _writer; } private readonly ReflectDefaultWriter _writer; @@ -48,7 +47,6 @@ namespace Avro.Reflect /// <summary> /// The schema /// </summary> - /// <value></value> public Schema Schema { get => _writer.Schema; } /// <summary>
