This is an automated email from the ASF dual-hosted git repository.

blachniet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git

commit 2dd342921cc7264a54cd66c00528381a167230f9
Author: Brian Lachniet <[email protected]>
AuthorDate: Sun Aug 18 21:48:26 2019 -0400

    AVRO-2454: Fix CA1721 - Property names should not match get methods
---
 lang/csharp/Avro.ruleset                          | 1 -
 lang/csharp/src/apache/main/GlobalSuppressions.cs | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/lang/csharp/Avro.ruleset b/lang/csharp/Avro.ruleset
index f40f63a..1c53123 100644
--- a/lang/csharp/Avro.ruleset
+++ b/lang/csharp/Avro.ruleset
@@ -29,7 +29,6 @@
     <Rule Id="CA1710" Action="Info" />
     <Rule Id="CA1716" Action="Info" />
     <Rule Id="CA1720" Action="Info" />
-    <Rule Id="CA1721" Action="Info" />
     <Rule Id="CA1801" Action="Info" />
     <Rule Id="CA1819" Action="Info" />
     <Rule Id="CA1820" Action="Info" />
diff --git a/lang/csharp/src/apache/main/GlobalSuppressions.cs 
b/lang/csharp/src/apache/main/GlobalSuppressions.cs
index 8bb0e31..4fafb70 100644
--- a/lang/csharp/src/apache/main/GlobalSuppressions.cs
+++ b/lang/csharp/src/apache/main/GlobalSuppressions.cs
@@ -40,4 +40,6 @@
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", 
"CA1065:Do not raise exceptions in unexpected locations", Justification = 
"Maintain public API", Scope = "member", Target = "~P:Avro.Protocol.MD5")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", 
"CA1308:Normalize strings to uppercase", Justification = "Maintain public API", 
Scope = "member", Target = 
"~M:Avro.Schema.GetTypeString(Avro.Schema.Type)~System.String")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", 
"CA1308:Normalize strings to uppercase", Justification = "Maintain public API", 
Scope = "member", Target = "~P:Avro.UnnamedSchema.Name")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", 
"CA1721:Property names should not match get methods", Justification = "Maintain 
public API", Scope = "member", Target = 
"~M:Avro.NamedSchema.GetName(Newtonsoft.Json.Linq.JToken,System.String)~Avro.SchemaName")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", 
"CA1721:Property names should not match get methods", Justification = "Maintain 
public API", Scope = "member", Target = "~P:Avro.NamedSchema.Name")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", 
"CA1724:Type names should not match namespaces", Justification = "Reviewed", 
Scope = "type", Target = "~T:Avro.Schema")]

Reply via email to