[
https://issues.apache.org/jira/browse/BEAM-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872932#comment-15872932
]
ASF GitHub Bot commented on BEAM-115:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2042
[BEAM-115,BEAM-1195] Build trigger state machine from Runner API Trigger
proto directly
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This replaces the case dispatch on the Java SDK's `Trigger` type with a
case dispatch on the Runner API's `Trigger` type. This is a step towards
`runners/core-java` executing triggers from any language.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam trigger-proto-state-machines
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2042.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2042
----
commit 7e4e37d0d2cb2fca1c12f67dedbf7b96cce3c6e5
Author: Kenneth Knowles <k...@google.com>
Date: 2017-02-18T00:05:13Z
Build trigger state machine from Runner API Trigger proto directly
----
> Beam Runner API
> ---------------
>
> Key: BEAM-115
> URL: https://issues.apache.org/jira/browse/BEAM-115
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-runner-api
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> The PipelineRunner API from the SDK is not ideal for the Beam technical
> vision.
> It has technical limitations:
> - The user's DAG (even including library expansions) is never explicitly
> represented, so it cannot be analyzed except incrementally, and cannot
> necessarily be reconstructed (for example, to display it!).
> - The flattened DAG of just primitive transforms isn't well-suited for
> display or transform override.
> - The TransformHierarchy isn't well-suited for optimizations.
> - The user must realistically pre-commit to a runner, and its configuration
> (batch vs streaming) prior to graph construction, since the runner will be
> modifying the graph as it is built.
> - It is fairly language- and SDK-specific.
> It has usability issues (these are not from intuition, but derived from
> actual cases of failure to use according to the design)
> - The interleaving of apply() methods in PTransform/Pipeline/PipelineRunner
> is confusing.
> - The TransformHierarchy, accessible only via visitor traversals, is
> cumbersome.
> - The staging of construction-time vs run-time is not always obvious.
> These are just examples. This ticket tracks designing, coming to consensus,
> and building an API that more simply and directly supports the technical
> vision.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
