[
https://issues.apache.org/jira/browse/BEAM-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877400#comment-15877400
]
ASF GitHub Bot commented on BEAM-115:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2065
[BEAM-115,BEAM-1348] Unify Runner API and Fn API coders
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Just shares `Coder`. Its a hack - it is really crufty to have side-by-side
int and string registries. But coders need to be by-reference. Options, off the
top of my head:
1. Make everything keyed on int64 (distasteful for debugging, but not
horrid).
2. Make everything keyed on string.
3. Make Fn API and harness really embrace separate registries by type.
4. Write 3 lines of conversion code, since sharing this one trivial proto
has only unclear benefit, while avoiding a hard dependency is almost always a
win.
R: @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam fn-api-coders-only
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2065
----
commit 3d4aed8fa4dfc9f1c69bb39692e92c16b3002df6
Author: Kenneth Knowles <k...@google.com>
Date: 2017-02-22T03:11:19Z
Unify Runner API and Fn API coders
----
> Beam Runner API
> ---------------
>
> Key: BEAM-115
> URL: https://issues.apache.org/jira/browse/BEAM-115
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-runner-api
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> The PipelineRunner API from the SDK is not ideal for the Beam technical
> vision.
> It has technical limitations:
> - The user's DAG (even including library expansions) is never explicitly
> represented, so it cannot be analyzed except incrementally, and cannot
> necessarily be reconstructed (for example, to display it!).
> - The flattened DAG of just primitive transforms isn't well-suited for
> display or transform override.
> - The TransformHierarchy isn't well-suited for optimizations.
> - The user must realistically pre-commit to a runner, and its configuration
> (batch vs streaming) prior to graph construction, since the runner will be
> modifying the graph as it is built.
> - It is fairly language- and SDK-specific.
> It has usability issues (these are not from intuition, but derived from
> actual cases of failure to use according to the design)
> - The interleaving of apply() methods in PTransform/Pipeline/PipelineRunner
> is confusing.
> - The TransformHierarchy, accessible only via visitor traversals, is
> cumbersome.
> - The staging of construction-time vs run-time is not always obvious.
> These are just examples. This ticket tracks designing, coming to consensus,
> and building an API that more simply and directly supports the technical
> vision.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
