[
https://issues.apache.org/jira/browse/BEAM-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998719#comment-15998719
]
ASF GitHub Bot commented on BEAM-2166:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2921
[BEAM-2166] Remove context from encoded byte size
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
Based on top of #2829
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam
remove_context_from_encoded_byte_size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2921.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2921
----
commit 202a92f5880d51dfa93db6cb90d63da1c070f808
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-05T17:08:32Z
Re-add AtomicCoder
This is a moderately useful base class for coders which take no
configuration.
commit 815e5765bdad35f72d441d7483f28124243e0a0c
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-05T17:10:40Z
Add default implementations of Coder methods to Coder
Remove from StructuredCoder. These are sensible defaults implemented in
terms of other Coder methods.
commit a94e403a1cdabf5f7c628dee6857d7333b2fc7c5
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-05T17:13:05Z
Reparent many Coders to Atomic or StructuredCoder
These coders do not take configuration, or take configuration only in
terms of other Coders, and are appropriate to reparent.
commit ffd58820eaed9117549e63920552000abb9e672d
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-05T17:13:41Z
Make CustomCoder extend Coder directly
CustomCoder in general consists of configuration beyond component
coders, and should not extend, for example, equality methods of
StrucutredCoder.
commit ae6b84d546a9b4b2bb7bcfd761634b5c55e7cf09
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-05T18:06:45Z
fixup! Add default implementations of Coder methods to Coder
commit ed35b56902d4f5785d4adc1e8861ca8378a730cf
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-05T18:12:46Z
Remove Context from getEncodedElementByteSize
----
> Remove Coder.Context from the public API
> ----------------------------------------
>
> Key: BEAM-2166
> URL: https://issues.apache.org/jira/browse/BEAM-2166
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py
> Affects Versions: First stable release
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Fix For: First stable release
>
>
> Justification:
> * Contexts add confusion and complexity to the public API (e.g.
> https://issues.apache.org/jira/browse/BEAM-1448)
> * Leaf (user-written) coders are nearly always nested.
> * Coders are being removed from sources, which was the initial need for
> context.
> * It is unclear how much value, if any, this provides for internal
> performance.
> * There may be performance (as well as simplification) gains in removing this
> for the Fn API.
> Fully removing this distinction from the internals can be defered until the
> last bullet points are more completely investigated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
