[ https://issues.apache.org/jira/browse/BEAM-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001430#comment-16001430 ]
ASF GitHub Bot commented on BEAM-2166: -------------------------------------- GitHub user robertwb opened a pull request: https://github.com/apache/beam/pull/2960 [BEAM-2166] Cherry-pick #2930 onto release-2.0.0 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertwb/incubator-beam coders-context-sizes-release Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2960.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2960 ---- ---- > Remove Coder.Context from the public API > ---------------------------------------- > > Key: BEAM-2166 > URL: https://issues.apache.org/jira/browse/BEAM-2166 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core, sdk-py > Affects Versions: 2.0.0 > Reporter: Robert Bradshaw > Assignee: Robert Bradshaw > Fix For: 2.0.0 > > > Justification: > * Contexts add confusion and complexity to the public API (e.g. > https://issues.apache.org/jira/browse/BEAM-1448) > * Leaf (user-written) coders are nearly always nested. > * Coders are being removed from sources, which was the initial need for > context. > * It is unclear how much value, if any, this provides for internal > performance. > * There may be performance (as well as simplification) gains in removing this > for the Fn API. > Fully removing this distinction from the internals can be defered until the > last bullet points are more completely investigated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)