[
https://issues.apache.org/jira/browse/BEAM-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999418#comment-15999418
]
ASF GitHub Bot commented on BEAM-1340:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2940
[BEAM-1340] Move TestDataflowRunner into dataflow package
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @davorbonaci
I believe the cost/benefit of this change make it worth consideration for
including in the first stable release.
There are two parts to this PR:
1. Register the `TestDataflowRunner` so that we don't have to fully qualify
it on the command line. This simplifies our poms and every testers life. This
is backwards compatible and makes configurations more robust. Note that every
other runner has their test runner registered.
2. Move the runners.dataflow.testing package to the runners.dataflow
package. This will allow the test runner to use package-private things, such as
transport helpers, etc, etc, (the list will only grow).
After the registrar change is in place, the second one is backwards
compatible except for programmatic uses, which would mean a user hardcoded the
runner in their Java code. So, while it is backwards incompatible in a
technical sense, the actual negative impact is ~zero.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam DataflowRunner-testing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2940
----
commit 307598202758f8d918e171dae3c8012ada50c38e
Author: Kenneth Knowles <k...@google.com>
Date: 2017-05-06T12:13:34Z
Register the TestDataflowRunner via registrar
commit 204a5254dfb0e36e348d64f13c8ea0fa325b6575
Author: Kenneth Knowles <k...@google.com>
Date: 2017-05-06T12:22:03Z
Move TestDataflowRunner into dataflow package
----
> Remove or make private public bits of the SDK that shouldn't be public
> ----------------------------------------------------------------------
>
> Key: BEAM-1340
> URL: https://issues.apache.org/jira/browse/BEAM-1340
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-java-extensions
> Reporter: Kenneth Knowles
> Priority: Blocker
> Labels: backward-incompatible
> Fix For: 2.0.0
>
>
> This JIRA is for the many small changes that do not merit their own JIRA
> towards getting the SDK's API surface right. For example, removal of
> `DoFn.InputProvider` and `DoFn.OutputReceiver`.
> While the above is not quite backwards incompatible, succeeding at this task
> surely will be.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
