[
https://issues.apache.org/jira/browse/BEAM-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265649#comment-16265649
]
ASF GitHub Bot commented on BEAM-3060:
--------------------------------------
chamikaramj commented on a change in pull request #4169: [BEAM-3060] Added
support for multiple filesystems in TextIO
URL: https://github.com/apache/beam/pull/4169#discussion_r153042101
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/TextIOIT.java
##########
@@ -81,13 +81,38 @@ public static void setup() throws ParseException {
.as(IOTestPipelineOptions.class);
numberOfTextLines = options.getNumberOfRecords();
- filenamePrefix = appendTimestamp(options.getFilenamePrefix());
+ filenamePrefix = resolveProtocolAndPath(options);
}
private static String appendTimestamp(String filenamePrefix) {
return String.format("%s_%s", filenamePrefix, new Date().getTime());
}
+ private static String resolveProtocolAndPath(IOTestPipelineOptions options) {
Review comment:
I'm not sure why we need to parse and reassemble protocol here. We shouldn't
have to do this if we ask user to give the full prefix that includes the
protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add performance tests for commonly used file-based I/O PTransforms
> ------------------------------------------------------------------
>
> Key: BEAM-3060
> URL: https://issues.apache.org/jira/browse/BEAM-3060
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Reporter: Chamikara Jayalath
> Assignee: Szymon Nieradka
>
> We recently added a performance testing framework [1] that can be used to do
> following.
> (1) Execute Beam tests using PerfkitBenchmarker
> (2) Manage Kubernetes-based deployments of data stores.
> (3) Easily publish benchmark results.
> I think it will be useful to add performance tests for commonly used
> file-based I/O PTransforms using this framework. I suggest looking into
> following formats initially.
> (1) AvroIO
> (2) TextIO
> (3) Compressed text using TextIO
> (4) TFRecordIO
> It should be possibly to run these tests for various Beam runners (Direct,
> Dataflow, Flink, Spark, etc.) and file-systems (GCS, local, HDFS, etc.)
> easily.
> In the initial version, tests can be made manually triggerable for PRs
> through Jenkins. Later, we could make some of these tests run periodically
> and publish benchmark results (to BigQuery) through PerfkitBenchmarker.
> [1] https://beam.apache.org/documentation/io/testing/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
