[
https://issues.apache.org/jira/browse/BEAM-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267283#comment-16267283
]
ASF GitHub Bot commented on BEAM-3060:
--------------------------------------
kamszPolidea commented on a change in pull request #4169: [BEAM-3060] Added
support for multiple filesystems in TextIO
URL: https://github.com/apache/beam/pull/4169#discussion_r153293304
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -100,4 +100,14 @@
String getFilenamePrefix();
void setFilenamePrefix(String prefix);
+
+ @Description("Google cloud storage - bucket_name/path")
+ String getGcsLocation();
Review comment:
We can use `--filenamePrefix`, but then we need to provide full
communication scheme there for GCS or HDFS, for instance
`gs://bucket/path/file` or `hdfs://hadoop-master:port/dfs-path/file`. If we
assume that user running tests will know it then those two gcsLocation and
hdfsLocation could be ommited. This is basically implementation of our proposal
https://docs.google.com/document/d/1dA-5s6OHiP_cz-NRAbwapoKF5MEC1wKps4A5tFbIPKE/edit#heading=h.29mfbxd6kc64
. Do you think would be better to remove those two pipeline options and just
depend on pipelinePrefix ? Should I also remove protocol resolving part then ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add performance tests for commonly used file-based I/O PTransforms
> ------------------------------------------------------------------
>
> Key: BEAM-3060
> URL: https://issues.apache.org/jira/browse/BEAM-3060
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Reporter: Chamikara Jayalath
> Assignee: Szymon Nieradka
>
> We recently added a performance testing framework [1] that can be used to do
> following.
> (1) Execute Beam tests using PerfkitBenchmarker
> (2) Manage Kubernetes-based deployments of data stores.
> (3) Easily publish benchmark results.
> I think it will be useful to add performance tests for commonly used
> file-based I/O PTransforms using this framework. I suggest looking into
> following formats initially.
> (1) AvroIO
> (2) TextIO
> (3) Compressed text using TextIO
> (4) TFRecordIO
> It should be possibly to run these tests for various Beam runners (Direct,
> Dataflow, Flink, Spark, etc.) and file-systems (GCS, local, HDFS, etc.)
> easily.
> In the initial version, tests can be made manually triggerable for PRs
> through Jenkins. Later, we could make some of these tests run periodically
> and publish benchmark results (to BigQuery) through PerfkitBenchmarker.
> [1] https://beam.apache.org/documentation/io/testing/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
