[ 
https://issues.apache.org/jira/browse/BEAM-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266077#comment-16266077
 ] 

ASF GitHub Bot commented on BEAM-3243:
--------------------------------------

rmannibucau commented on issue #4172: [BEAM-3243] support multiple anonymous 
classes from the same enclosing class in a pipeline
URL: https://github.com/apache/beam/pull/4172#issuecomment-347019445
 
 
   I understand where it comes from but it is very boring when writing tests 
where it is not uncommon to write anonymous classes and the inline naming is 
not always doable when you write utility methods or reusable piece of pipelines.
   
   You would also note that anonymous algorithm with the "number" is somehow 
aligned on the fact to keep only the suffix in the nested class case which 
leads to as meaningless names (Important$Stuff leads to Stuff which is in 
general not very meaningful for the "task" context since it is hold by the 
enclosing class to avoid long and repeating names).
   
   The original issue is when it fails it is quite abstract and not very 
obvious. An alternative can be to enrich the error message with:
   
   1. where the anonymous *classes* (all conflicting ones) are
   2. how to fix it - passing a name to the apply
   
   I would be fine with this "not solution" fix as well, does it sound better 
for you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> multiple anonymous DoFn lead to conflicting names
> -------------------------------------------------
>
>                 Key: BEAM-3243
>                 URL: https://issues.apache.org/jira/browse/BEAM-3243
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core
>            Reporter: Romain Manni-Bucau
>            Assignee: Romain Manni-Bucau
>             Fix For: 2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to